Skip to content

Add 3 Auth Provider Icons #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025
Merged

Conversation

bilgilendir
Copy link
Contributor

@bilgilendir bilgilendir commented Apr 19, 2025

Description:

  • Added icons for the following auth providers:

    • ImmoScout24
    • Bonify
    • Agentur für Arbeit
  • Updated assets/custom-icons/_data/custom-icons.json accordingly.

  • Reordered one icon name ascending

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2025

CLA assistant check
All committers have signed the CLA.

@bilgilendir
Copy link
Contributor Author

You can proceed with the necessary updates to merge this, or feel free to fork it into your own account if preferred.

@sv3nnie
Copy link
Contributor

sv3nnie commented Apr 25, 2025

LinkedIn got removed from Simple Icons due to trademark issues: simple-icons/simple-icons#10019. Not sure how Ente wants to approach this.

@bilgilendir
Copy link
Contributor Author

Thanks for the note. That's a good point to know!
In that sense all icons can potentially involve a trademark issue.
It’s up to the Ente team to decide what’s appropriate to include.

@sv3nnie
Copy link
Contributor

sv3nnie commented Apr 26, 2025

HEX is optional. Only set the HEX color in the custom-icons.json if you want to overwrite all colors in the SVG. For example, Bonify’s HEX is set to 2eacbd, which will also change the black areas of the SVG to this color.

I also noticed that the LinkedIn icon was recently merged in another PR: #5284 #5727.

@bilgilendir
Copy link
Contributor Author

@sv3nnie Thanks, updated per your suggestions!

@ua741
Copy link
Member

ua741 commented Apr 29, 2025

@bilgilendir Thank you for the PR. Can you please resolve the merge conflicts to that we can start linter & process to merge these changes.

@bilgilendir bilgilendir changed the title Add 4 Auth Provider Icons Add 3 Auth Provider Icons Apr 29, 2025
@bilgilendir
Copy link
Contributor Author

@ua741 Thanks, resolved.

@ua741 ua741 enabled auto-merge (squash) April 30, 2025 03:56
@ua741 ua741 merged commit 223961b into ente-io:main Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants