feat: support targetRef in backend security policy #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xunzhuo
force-pushed
the
feat-use-targetref
branch
from
d224f4e to
f59d331
Compare
Signed-off-by: bitliu <[email protected]>
Xunzhuo
force-pushed
the
feat-use-targetref
branch
from
f59d331 to
126cc7b
Compare
|
Yes, I did this earlier than the discussion, so let us hold. |
mathetake
reviewed
Jul 3, 2025
|
i will take over this pr |
# Conflicts: # api/v1alpha1/api.go # internal/controller/ai_service_backend.go # internal/controller/backend_security_policy_test.go # tests/controller/controller_test.go
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
|
i pushed some changes. PTAL @Xunzhuo |
|
thanks @mathetake! |
Xunzhuo
commented
Jul 26, 2025
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
approved these changes
Jul 26, 2025
mathetake
added a commit
that referenced
this pull request
Jul 30, 2025
**Description** backendSecurityPolicyRef has been marked deprecated, so this cleans up the remaining reference of backendSecurityPolicyRef in various places. **Related Issues/PRs (if applicable)** Follow up on #762 Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a new targetRefs field to BackendSecurityPolicy to match the recommended pattern of GWAPI. This means that we will deprecate backendSecurityPolicyRef of AIServiceBackend. It will continue working as-is, but the API will be dropped after v0.3 is released. Users are advised to migrate to the new API with the instruction in the documentation.
Related Issues/PRs (if applicable)
Fixes: #549