-
Notifications
You must be signed in to change notification settings - Fork 27
Show how to set custom_tags for tracing #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adil Hafeez <[email protected]>
1be6e85
to
c08a403
Compare
Signed-off-by: Adil Hafeez <[email protected]>
Signed-off-by: Adil Hafeez <[email protected]>
@phlax pls take a look |
Signed-off-by: Adil Hafeez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this needs a bit more documentation to show how the custom tags are used - and something in the verify.sh
to ensure its working as expected
Co-authored-by: phlax <[email protected]> Signed-off-by: Adil Hafeez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adilhafeez i would like to land this but it really does need some explanation in the docs as to how to add tags
No description provided.