combine the xds-translator and xds-server runner into one #6586
+660
−794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
changed the title
* primarily to reduce memory and convergence time Some stats collected with 1000 HTTPRoutes configured | Metric | **Before** | **After** | **Change** | | --------------------------------- | ------------------------------ | ---------------------------------- | -------------- | | `go_memstats_sys_bytes` | 452,736,360 bytes (\~431.6 MB) | **231,597,336 bytes (\~220.8 MB)** | **↓ \~210 MB** | | `go_memstats_alloc_bytes` | 68,811,456 bytes (\~65.6 MB) | **61,314,944 bytes (\~58.5 MB)** | ↓ \~7 MB | | `go_memstats_heap_idle_bytes` | 306,855,936 bytes (\~292.7 MB) | **70,557,184 bytes (\~67.3 MB)** | ↓ \~225 MB | | `go_memstats_heap_released_bytes` | 286,351,360 bytes (\~273.1 MB) | **51,478,528 bytes (\~49.1 MB)** | ↓ \~224 MB | | `go_memstats_heap_sys_bytes` | 428,310,528 bytes (\~408.4 MB) | **139,657,216 bytes (\~133.2 MB)** | ↓ \~275 MB | Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (38.23%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6586 +/- ##
==========================================
+ Coverage 71.03% 71.26% +0.23%
==========================================
Files 225 224 -1
Lines 39155 39100 -55
==========================================
+ Hits 27813 27865 +52
+ Misses 9732 9611 -121
- Partials 1610 1624 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can we have the diff in benchmark to see the differences? curious about how it can improve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.