-
Notifications
You must be signed in to change notification settings - Fork 42
I1039 Finishes executeFromSelfReg #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Int test and would run the wrong test in sbt
…an attempt IS made to use the default value vs not made in the other cases
kushti
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update LangSpec.md as well
sc/shared/src/test/scala/sigmastate/utxo/BasicOpsSpecification.scala
Outdated
Show resolved
Hide resolved
sc/shared/src/test/scala/sigmastate/utxo/BasicOpsSpecification.scala
Outdated
Show resolved
Hide resolved
… being thrown and default value is indeed returned.
kushti
requested changes
Mar 12, 2025
jozanek
reviewed
Mar 15, 2025
jozanek
reviewed
Mar 15, 2025
jozanek
reviewed
Mar 17, 2025
jozanek
reviewed
Mar 17, 2025
…teFromSelfReg implementation that doesn't take a default value.
More documentation meta. .
kushti
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but please address notes!
…pdate documentation to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements executeFromSelfReg like executeFromVar. Closes #1039.