Skip to content

Feat/add named registration for mongodb #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sdkaraarslan
Copy link
Collaborator

closes #1 and #2

@snovak7 snovak7 self-requested a review August 26, 2023 13:56
@snovak7 snovak7 added this to the v0.1.0 milestone Aug 26, 2023
/// <value>The username.</value>
public TimeSpan HearbeatInterval { get; set; }

// Add more options here as neccesary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the most important properties are missing

Least expected are HostName/Endpoints, Username, Password

/// <param name="name">The name.</param>
/// <param name="optionName">The named option.</param>
/// <returns>The updated host builder.</returns>
public static IHostBuilder AddMongoDbClientFromOption(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming! check #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add named registration for mongodb options
2 participants