Skip to content

Add get_digital_data_sincelast to librador #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

couchand
Copy link
Contributor

@couchand couchand commented Jan 14, 2022

To mirror the get_analog_data_sincelast method on the digital side, I've added the function get_digital_data_sincelast.

I've made a mistake in the math that I have yet to identify -- it's not yet returning the right number of subsamples. I will work that out and update this PR.

In the meantime, I thought I would open a draft here, to get your thoughts on adding this to the API. Let me know what you think!

@EspoTek
Copy link
Collaborator

EspoTek commented Jan 19, 2022

Honestly man, any new feature that is added to the API is awesome!

Let us know when you're ready to pull and I'll push it through.

@mi-hol
Copy link
Contributor

mi-hol commented Feb 10, 2025

@couchand appreciate your contribution, but it's state is unclear currently.
Are you planning to complete development?

@mi-hol mi-hol added stale no progess made, will be closed soon feedback_requested labels Feb 10, 2025
@couchand
Copy link
Contributor Author

Hi @mi-hol, to be honest there is just so much I've wanted to be doing with this beautiful little device but I haven't gotten around to any of it recently, unfortunately.

I'd love to pick this up again, not sure when that will be. Happy to answer any questions if you'd like to take it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no progess made, will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants