Optimize code analysis allocation #1215
Open
+56
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 94.52% 94.53%
=======================================
Files 175 175
Lines 19638 19655 +17
=======================================
+ Hits 18563 18580 +17
Misses 1075 1075
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gumb0
reviewed
May 7, 2025
|
|
||
| const auto padded_code_size = code.size() + PADDING; | ||
| const auto aligned_code_size = |
There was a problem hiding this comment.
Why not make a struct of code + bitset_words and allocate that?
There was a problem hiding this comment.
Yes, both arrays are dynamic size :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct analyzed code with single allocation. This replaces two allocations: one for the code copy and one for the jumpdest bitset with a single one of the following layout:
ceil(code.size() / 64)bits)