-
Notifications
You must be signed in to change notification settings - Fork 20.8k
core/state: introduce the TransitionState object (verkle transition part 1) #31634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gballet
wants to merge
5
commits into
ethereum:master
Choose a base branch
from
gballet:rebase-master-add-transition-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
core/state: introduce the TransitionState object (verkle transition part 1) #31634
gballet
wants to merge
5
commits into
ethereum:master
from
gballet:rebase-master-add-transition-state
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Apr 28, 2025
core/state/database.go
Outdated
// SaveTransitionState saves the tree transition progress markers to the database. | ||
SaveTransitionState(common.Hash, *TransitionState) | ||
|
||
// LoadTransitionState loads the tree transition progress markers from the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gary: move this to the cachingdb
gballet
commented
Apr 28, 2025
core/state/database.go
Outdated
@@ -141,6 +151,50 @@ type Trie interface { | |||
IsVerkle() bool | |||
} | |||
|
|||
// TransitionState is a structure that holds the progress markers of the | |||
// translation process. | |||
type TransitionState struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to its own package
bb038c6
to
7352993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #31532
It maintains a series of conversion maker which are to be updated by the conversion code (in a follow-up PR, this is a breakdown of a larger PR to make things easier to review). They can be used in two modes:
EnableVerkleAtGenesis
.Part of #31583