miner, core, core/txpool: implement EIP 7825 - Transaction Gas Limit Cap #31824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
commented
May 14, 2025
jwasinger
requested review from
fjl,
karalabe,
gballet,
rjl493456442,
zsfelfoldi and
MariusVanDerWijden
as code owners
|
IMO the one thing missing here is test coverage. I'm thinking that some the test coverage will end up in hive tests, and STEEL can probably be responsible for implementing these. But as this PR is written now, there are edge-cases which probably need to be tested as unit tests: see my comment in |
MariusVanDerWijden
force-pushed
the
eip-7825
branch
from
ea7bbe4 to
af879b0
Compare
rjl493456442
reviewed
Jun 9, 2025
rjl493456442
previously approved these changes
Jun 12, 2025
lightclient
dismissed stale reviews from MariusVanDerWijden and rjl493456442
via
b6256ef
rjl493456442
previously approved these changes
Jul 8, 2025
fjl
reviewed
Jul 8, 2025
params/protocol_params.go
Outdated
| CallValueTransferGas uint64 = 9000 // Paid for CALL when the value transfer is non-zero. | ||
| CallNewAccountGas uint64 = 25000 // Paid for CALL when the destination address didn't exist prior. | ||
| TxGas uint64 = 21000 // Per transaction not creating a contract. NOTE: Not payable on data of calls between transactions. | ||
| MaxTxGas uint64 = 30_000_000 // eip-7825 maximum transaction gas limit |
There was a problem hiding this comment.
This constant should not be in the middle of the list here, but have its own paragraph.
MariusVanDerWijden
approved these changes
Jul 8, 2025
rjl493456442
added a commit
that referenced
this pull request
Aug 5, 2025
This PR makes 2 changes to how [EIP-7825](#31824) behaves. When `eth_estimateGas` or `eth_createAccessList` is called without any gas limit in the payload, geth will choose the block's gas limit or the `RPCGasCap`, which can be larger than the `maxTxGas`. When this happens for `estimateGas`, the gas estimation just errors out and ends, when it should continue doing binary search to find the lowest possible gas limit. This PR will: - Add a check to see if `hi` is larger than `maxTxGas` and cap it to `maxTxGas` if it's larger. And add a special case handling for gas estimation execute when it errs with `ErrGasLimitTooHigh` --------- Co-authored-by: Gary Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements EIP-7825