eth/tracers: add console.log/error support to JS tracer #31826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will not work when the console log requires some formatting. And I don't think we should implement the logic for that. Either we use goja-node for it or really just ignore this for now. I don't think ton of people need this thing. |
|
Oh, I was looking through the geth console code (still learning!) and noticed this TODO comment. Is this one still needed? If not, I can clean it up and remove the TODO—just let me know! @s1na |
|
Ok thanks but I think the console is not super crucial. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemnt the console.log and console.error for js tracer