Skip to content

Python 3 compatibility #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Python 3 compatibility #18

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa83cfb
support for Python 3.4
smcoll May 31, 2017
2ebe76a
made match non-greedy so tests are more reliable
smcoll May 31, 2017
43e00a8
tests pass in Python 3.5
smcoll May 31, 2017
c5dc72b
remove ROOT_URLCONF to pass tests in Django 1.11
smcoll May 31, 2017
25684c1
Travix config to test on Python 3.2-3.5 in addition to 2.7
smcoll May 31, 2017
054ff26
drop explicit support for 3.2 and 3.3 because a specific version of D…
smcoll May 31, 2017
bebf544
add python 3.6 support and a additional classifiers
smcoll Oct 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ language: python

python:
- "2.7"
- "3.4"
- "3.5"

before_install:
- "pip install --upgrade pip wheel"
Expand Down
2 changes: 2 additions & 0 deletions rest_framework_httpsignature/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import unicode_literals

from rest_framework import authentication
from rest_framework import exceptions
from httpsig import HeaderSigner
Expand Down
4 changes: 3 additions & 1 deletion rest_framework_httpsignature/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import unicode_literals

from django.test import SimpleTestCase, TestCase, RequestFactory
from django.contrib.auth import get_user_model
from rest_framework_httpsignature.authentication import SignatureAuthentication
Expand Down Expand Up @@ -137,7 +139,7 @@ def test_build_signature(self):
signature_string = self.auth.build_signature(
self.KEYID, SECRET, req)
signature = re.match(
'.*signature="(.+)",?.*', signature_string).group(1)
r'.*signature="(.*?)",?.*', signature_string).group(1)
self.assertEqual(expected_signature, signature)


Expand Down
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
'Framework :: Django',
'Operating System :: OS Independent',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add these?

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: Implementation :: CPython',

'License :: OSI Approved :: MIT License',
'Topic :: Internet :: WWW/HTTP',
'Topic :: Security',
Expand Down
2 changes: 0 additions & 2 deletions test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,4 @@
'rest_framework_httpsignature',
)

ROOT_URLCONF = 'rest_framework_httpsignature.tests'

SECRET_KEY = 'MY PRIVATE SECRET'