Add list-ops #159
Merged
Add list-ops #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiravillekode
force-pushed
the
list-ops
branch
2 times, most recently
from
96e89cc to
25a4d15
Compare
ahans
approved these changes
May 13, 2025
generators/exercises/list_ops.py
Outdated
| """ | ||
|
|
||
| def array_literal(digits): | ||
| return '{' + ', '.join(str(d) for d in digits) + '}' |
generators/exercises/list_ops.py
Outdated
Comment on lines
98
to
111
| if prop == 'append': | ||
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | ||
| call = f'{prop}(buffer, {list1_with_count}, {list2_with_count})' | ||
|
|
||
| if prop in ['filter', 'map']: | ||
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | ||
| call = f'{prop}(buffer, {list_with_count}, {function})' | ||
|
|
||
| if prop in ['foldl', 'foldr']: | ||
| call = f'{prop}({list_with_count}, {initial}, {function})' | ||
|
|
||
| if prop == 'reverse': | ||
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | ||
| call = f'{prop}(buffer, {list_with_count})' |
There was a problem hiding this comment.
You should use elif to avoid evaluations that for sure will be false. Or use pattern matching:
Suggested change
| if prop == 'append': | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list1_with_count}, {list2_with_count})' | |
| if prop in ['filter', 'map']: | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list_with_count}, {function})' | |
| if prop in ['foldl', 'foldr']: | |
| call = f'{prop}({list_with_count}, {initial}, {function})' | |
| if prop == 'reverse': | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list_with_count})' | |
| match prop: | |
| case 'append': | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list1_with_count}, {list2_with_count})' | |
| case 'filter' | 'map': | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list_with_count}, {function})' | |
| case 'foldl' | 'foldr': | |
| call = f'{prop}({list_with_count}, {initial}, {function})' | |
| case 'reverse': | |
| str_list.append('int64_t buffer[BUFFER_SIZE];\n') | |
| call = f'{prop}(buffer, {list_with_count})' |
generators/exercises/list_ops.py
Outdated
| } | ||
| """ | ||
|
|
||
| def array_literal(digits): |
There was a problem hiding this comment.
Those are not necessarily digits, right? Maybe call it values or numbers instead?
| .globl reverse | ||
|
|
||
|
|
||
| /* extern size_t append(int64_t* buffer, const int64_t* list1, size_t list1_count, const int64_t* list2, size_t list2_count); */ |
There was a problem hiding this comment.
To be consistent with list_ops_test.c (but really nit picking here ...):
Suggested change
| /* extern size_t append(int64_t* buffer, const int64_t* list1, size_t list1_count, const int64_t* list2, size_t list2_count); */ | |
| /* extern size_t append(int64_t *buffer, const int64_t *list1, size_t list1_count, const int64_t *list2, size_t list2_count); */ |
Also applies to other C function signatures in this file.
| mov x15, x2 | ||
| lsl x9, x2, #3 | ||
| add x9, x1, x9 /* end of list */ | ||
| cbz x2, .reverse_return |
There was a problem hiding this comment.
Wouldn't it be better to move this before line 170?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.