Skip to content

Add atbash-cipher decode tests #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Add atbash-cipher decode tests #872

merged 1 commit into from
May 5, 2025

Conversation

verdammelt
Copy link
Member

These tests were never implemented (but were listed in the tests.toml
file as if they had been).

Fixes #871

These tests were never implemented (but were listed in the tests.toml
file as if they had been).
Copy link

github-actions bot commented May 4, 2025

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Copy link

github-actions bot commented May 4, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@verdammelt verdammelt requested a review from BNAndras May 4, 2025 22:48
@verdammelt
Copy link
Member Author

@BNAndras I found it rather simple (and a nice distraction) to implement these missing tests. Could you give them a quick review? Thanks.

@verdammelt verdammelt merged commit 08a130f into main May 5, 2025
8 checks passed
@verdammelt verdammelt deleted the add-atbash-decode-tests branch May 5, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atbash Cipher should have tests for decoding.
2 participants