Fix View Coopting View edge case on Android #52066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76745057 |
|
This pull request was exported from Phabricator. Differential Revision: D76745057 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52066 Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Differential Revision: D76745057
jorge-cab
force-pushed
the
export-D76745057
branch
from
6742622 to
1adaea3
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: facebook#52066 Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Differential Revision: D76745057
jorge-cab
force-pushed
the
export-D76745057
branch
from
1adaea3 to
708b994
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76745057 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jun 23, 2025
Summary: Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76745057
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jun 24, 2025
Summary: Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76745057
Summary: Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76745057
jorge-cab
force-pushed
the
export-D76745057
branch
from
708b994 to
6dff8bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76745057 |
|
This pull request has been merged in 8cc2874. |
|
This pull request was successfully merged by @jorge-cab in 8cc2874 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility.
Instead of disabling by setting
important for accessibility = nonow we just setisFocusable = falsewhich disables focusing but still allows parent views to cooptChangelog: [Internal]
Differential Revision: D76745057