Do not export PublicRootInstance and PublicTextInstance #53271
+7
−274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80254441 |
|
) Summary: Changelog: [internal] `VirtualView` has been exposed as an unstable API in the `react-native` package but its public API is referencing the DOM APIs, which forces their definitions to also be public (but shouldn't because they haven't been released yet). This replaces the reference with a reference to `HostInstance`, which will be updated to reference the DOM APIs when ready. Differential Revision: D80254442
Summary: Changelog: [internal] These types aren't used in `react-native` at the moment. They are only relevant when enabling the DOM APIs, which haven't been enabled in OSS yet. Differential Revision: D80254441
rubennorte
force-pushed
the
export-D80254441
branch
from
3e707bc to
d1bfd75
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 14, 2025
Summary: Changelog: [internal] These types aren't used in `react-native` at the moment. They are only relevant when enabling the DOM APIs, which haven't been enabled in OSS yet. Differential Revision: D80254441
|
This pull request was exported from Phabricator. Differential Revision: D80254441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
These types aren't used in
react-nativeat the moment. They are only relevant when enabling the DOM APIs, which haven't been enabled in OSS yet.Differential Revision: D80254441