Add benchmarks for console.timeStamp #53294
Open
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80272873 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 15, 2025
Summary: Changelog: [internal] Just adding a benchmark for `console.timeStamp`, which in normal circumstances will just measure a no-op. We can force installing the inspector and simulate that we're profiling in Fantom to force `console.timeStamp` to go through the tracing paths for the benchmark. Reviewed By: rshest Differential Revision: D80272873
rubennorte
force-pushed
the
export-D80272873
branch
from
ccba393 to
7e6c11a
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 16, 2025
Summary: Changelog: [internal] Just adding a benchmark for `console.timeStamp`, which in normal circumstances will just measure a no-op. We can force installing the inspector and simulate that we're profiling in Fantom to force `console.timeStamp` to go through the tracing paths for the benchmark. Reviewed By: rshest Differential Revision: D80272873
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 16, 2025
Summary: Changelog: [internal] Just adding a benchmark for `console.timeStamp`, which in normal circumstances will just measure a no-op. We can force installing the inspector and simulate that we're profiling in Fantom to force `console.timeStamp` to go through the tracing paths for the benchmark. Reviewed By: rshest Differential Revision: D80272873
Summary: Pull Request resolved: facebook#53294 Changelog: [internal] Just adding a benchmark for `console.timeStamp`, which in normal circumstances will just measure a no-op. We can force installing the inspector and simulate that we're profiling in Fantom to force `console.timeStamp` to go through the tracing paths for the benchmark. Reviewed By: rshest Differential Revision: D80272873
|
This pull request was exported from Phabricator. Differential Revision: D80272873 |
rubennorte
force-pushed
the
export-D80272873
branch
from
7e6c11a to
8873c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just adding a benchmark for
console.timeStamp, which in normal circumstances will just measure a no-op. We can force installing the inspector and simulate that we're profiling in Fantom to forceconsole.timeStampto go through the tracing paths for the benchmark.Reviewed By: rshest
Differential Revision: D80272873