Feature unsynn quote #759
Draft
Feature unsynn quote #759
+9
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsynn re-exports the proc_macro2 entities. This was done to eleminate the need of an additionaly dependency which version may become out of sync with the one unsynn uses.
unsynn 0.2 will include its own simple quote!{} macro
cehteh
force-pushed
the
feature-unsynn-quote
branch
from
a5628b7 to
b56ea69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yo Amos!
I see you like quote!, so I removed quote from facet and put quote in unsynn, now you can quote without depending or quote! (also the proc_macro2 dependency is gone)
Short story, long:
This is WIP/anticipatory of a not yet released unsynn 0.2 which will include its own quote! macro. for $reasons it will be slightly different (simpler) to the quote crate. there are no
#()repetitions yet. But this can be easily handled see the patch.Initially i was thinking i could just
impl quote::ToTokens for dyn unsynn::ToTokens ..but unfortunally this didnt worked out, either because thequote::quote!()macro can't handle that or because the trait solver isn't smart enough. Anyway, i just got my "Hold my beer" moment yesterday: How complicated can aquote!{}in unsynn be? .. turns out its pretty trivial to do the basics. So unsynn has its own leanquote!{}macro now.This is yet just a Draft PR (don't merge!) up for comment. For now I only touched
facet-macros-parseI'll see to remove proc_macro2 deps (its reexported from unsynn) and quote from the rest of facet while going over it. Its a nice test case to me to see where unsynn lacks features.