[Common] Replace hardcoded SDK version with Config.OLDEST_SDK (2) #7060
Conversation
Firebase AI Mock Responses Check
|
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily aims to modernize test configurations by replacing specific hardcoded Android SDK versions with a dynamic Config.OLDEST_SDK constant. This change aligns tests with the project's minimum supported SDK, preparing for future minSdk bumps. Additionally, a minor correction was made to a user agent pattern in one of the tests to ensure correct assertion behavior.
Highlights
- Standardize Test SDK Configuration: Replaced hardcoded Android SDK versions (e.g., API 21, API 22) in test configurations with
Config.OLDEST_SDK. This ensures tests consistently run against the project's minimum supported SDK version, simplifying maintenance as theminSdkevolves. - Fix User Agent Pattern: Corrected a regex pattern in
FirebasePlatformLoggingTestfromandroid-platformtoandroid-installerfor user agent string matching. This addresses an apparent bug in the test's assertion logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
This pull request updates two test files to use Config.OLDEST_SDK instead of hardcoded SDK versions, which improves maintainability as the minimum SDK changes over time. The changes are consistent with the PR's goal. I have one point of feedback regarding a change in a test assertion that accompanies the SDK version update, for which I've requested clarification.
| @@ -98,7 +98,7 @@ public void test_auto_atNotHighEnoughApiLevel() { | |||
| app -> { | |||
| UserAgentPublisher ua = app.get(UserAgentPublisher.class); | |||
|
|
|||
| assertThat(ua.getUserAgent()).containsMatch(Pattern.compile("android-platform/($|\\s)")); | |||
| assertThat(ua.getUserAgent()).containsMatch(Pattern.compile("android-installer/($|\\s)")); | |||
There was a problem hiding this comment.
This change updates the expected user agent string from android-platform/ to android-installer/. While this might be correct due to the change in SDK version for this test (from LOLLIPOP_MR1 to OLDEST_SDK), it's a functional change in the test's expectation that isn't explained in the pull request description.
Could you please clarify why this change is needed? For example, is there a specific SDK level where the fallback behavior for platform detection changes from an empty platform string to an empty installer string?
Adding a brief explanation to the PR description would be helpful for future readers to understand the context of this change.
Coverage Report 1Affected ProductsNo changes between base commit (9b510c4) and merge commit (e3c2fc9).Test Logs |
Test Results 50 files - 1 008 50 suites - 1 008 1m 8s ⏱️ - 34m 16s Results for commit 9a869a3. ± Comparison against base commit 9b510c4. This pull request removes 5909 tests. |
Size Report 1Affected ProductsNo changes between base commit (9b510c4) and merge commit (e3c2fc9).Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
Tests will use the Config.OLDEST_SDK instead of a hardcoded SDK if the corresponding hardcoded SDK would be below our intended minSdk.
I'll also need to re-evaluate whether these tests are necessary to keep around, or if they are irrelevant when bumping the minSdk.
Related to cl/769912845