-
Notifications
You must be signed in to change notification settings - Fork 624
Upgrade ktor to 3.1.3 to avoid conflict version when use in KMP project #7062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hieuwu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a targeted dependency upgrade aimed at resolving a critical class conflict. By bumping the Ktor library version, it ensures seamless integration and prevents runtime errors when the firebase-ai
module is used alongside other Ktor dependencies in a consuming application, thereby enhancing the overall stability and compatibility of the SDK.
Highlights
- Dependency Upgrade: I've upgraded the Ktor library version from
2.3.2
to3.1.3
in the project's dependency management file. - Compatibility Fix: This upgrade specifically addresses a
NoClassDefFoundError
(related toHttpTimeout
) that occurs whenfirebase-ai
is used in projects that also depend on Ktor, resolving a version conflict issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades Ktor from version 2.3.2 to 3.1.3 to resolve a dependency conflict when using firebase-ai
with newer versions of Ktor in a user's project. While the version bump is necessary, upgrading a major version of a library like Ktor can introduce breaking changes. I've added a comment to inquire about whether the necessary code adaptations and regression testing have been performed to ensure this upgrade is safe for the SDK.
@@ -46,7 +46,7 @@ jsonassert = "1.5.0" | |||
kotest = "5.9.0" # Do not use 5.9.1 because it reverts the fix for https://github.com/kotest/kotest/issues/3981 | |||
kotestAssertionsCore = "5.8.1" | |||
kotlin = "1.8.22" | |||
ktorVersion = "2.3.2" | |||
ktorVersion = "3.1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading Ktor from version 2.x to 3.x is a major version change that can introduce breaking API changes. For example, the HttpTimeout
plugin, which seems related to the issue you're fixing, has been significantly reworked in Ktor 3.
Could you please confirm that you've:
- Analyzed the Ktor 3.0 migration guide for any necessary code changes in modules that use Ktor (like
firebase-ai
)? - Run all relevant tests to ensure that this version bump doesn't introduce any regressions?
This is important to ensure the stability of the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated in 80d02de .
Summary
Upgrade ktor to 3.1.3 resolve #7061
When use firebase-ai in project that uses ktor:
Adding firebase-ai causes conflict of
ktor
classesWhen run through code that sets up firebase-ai:
It throws:
Solution
Because
firebase-ai
is using oudated ktor, it causes class conflict when add the library. So ktor needs to be upgraded to avoid