Skip to content

Upgrade ktor to 3.1.3 to avoid conflict version when use in KMP project #7062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hieuwu
Copy link

@hieuwu hieuwu commented Jun 21, 2025

Summary

Upgrade ktor to 3.1.3 resolve #7061
When use firebase-ai in project that uses ktor:

implementation("io.ktor:ktor-client-plugins:3.1.1")
implementation("io.ktor:ktor-client-core:3.1.3")
implementation("io.ktor:ktor-client-okhttp:3.1.3")
implementation("io.ktor:ktor-client-content-negotiation:3.1.3")
implementation("io.ktor:ktor-serialization-kotlinx-json:3.1.3")

Adding firebase-ai causes conflict of ktor classes

implementation(platform("com.google.firebase:firebase-bom:33.15.0"))
implementation("com.google.firebase:firebase-ai") 

When run through code that sets up firebase-ai:

val model = Firebase.ai(backend = GenerativeBackend.googleAI())
  .generativeModel("gemini-2.5-flash")

It throws:

 Process: com.crafted.kudossnap.android, PID: 22877
 java.lang.NoClassDefFoundError: Failed resolution of: Lio/ktor/client/plugins/HttpTimeout;
 	at com.google.firebase.ai.common.APIController$client$1.invoke(APIController.kt:127)
 	at com.google.firebase.ai.common.APIController$client$1.invoke(APIController.kt:126)

Solution

Because firebase-ai is using oudated ktor, it causes class conflict when add the library. So ktor needs to be upgraded to avoid

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hieuwu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a targeted dependency upgrade aimed at resolving a critical class conflict. By bumping the Ktor library version, it ensures seamless integration and prevents runtime errors when the firebase-ai module is used alongside other Ktor dependencies in a consuming application, thereby enhancing the overall stability and compatibility of the SDK.

Highlights

  • Dependency Upgrade: I've upgraded the Ktor library version from 2.3.2 to 3.1.3 in the project's dependency management file.
  • Compatibility Fix: This upgrade specifically addresses a NoClassDefFoundError (related to HttpTimeout) that occurs when firebase-ai is used in projects that also depend on Ktor, resolving a version conflict issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades Ktor from version 2.3.2 to 3.1.3 to resolve a dependency conflict when using firebase-ai with newer versions of Ktor in a user's project. While the version bump is necessary, upgrading a major version of a library like Ktor can introduce breaking changes. I've added a comment to inquire about whether the necessary code adaptations and regression testing have been performed to ensure this upgrade is safe for the SDK.

@@ -46,7 +46,7 @@ jsonassert = "1.5.0"
kotest = "5.9.0" # Do not use 5.9.1 because it reverts the fix for https://github.com/kotest/kotest/issues/3981
kotestAssertionsCore = "5.8.1"
kotlin = "1.8.22"
ktorVersion = "2.3.2"
ktorVersion = "3.1.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading Ktor from version 2.x to 3.x is a major version change that can introduce breaking API changes. For example, the HttpTimeout plugin, which seems related to the issue you're fixing, has been significantly reworked in Ktor 3.

Could you please confirm that you've:

  • Analyzed the Ktor 3.0 migration guide for any necessary code changes in modules that use Ktor (like firebase-ai)?
  • Run all relevant tests to ensure that this version bump doesn't introduce any regressions?

This is important to ensure the stability of the SDK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated in 80d02de .

@hieuwu hieuwu changed the title Upgrade ktor to 3.1.3 to avoid conflict version Upgrade ktor to 3.1.3 to avoid conflict version when use in KMP project Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class from Ktor not found exception when add firebase-ai to android module in KMP project, when use library with Ktor 3.3.1 in shared module
1 participant