[WIP] fix(vmm): Do not store UFFD handle in VMM #5341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5341 +/- ##
=========================================================
- Coverage 81.96% 81.91% -0.06%
=========================================================
Files 250 250
Lines 27570 27571 +1
=========================================================
- Hits 22599 22584 -15
- Misses 4971 4987 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
force-pushed
the
kill_fault_all
branch
from
9ec5372 to
e928650
Compare
roypat
force-pushed
the
feature/secret-hiding
branch
from
e296ba2 to
0c80a95
Compare
kalyazin
force-pushed
the
kill_fault_all
branch
2 times, most recently
from
bbb0dee to
efff1a4
Compare
kalyazin
changed the title
kalyazin
force-pushed
the
kill_fault_all
branch
3 times, most recently
from
5611b1f to
5775fb4
Compare
This is to unregister all UFFD ranges when the UFFD handler is disconnected so that no further UFFD message is sent if the handler is not longer available.
The test verifies that if the fault-all handler exits, the VM is still functional. THe test is mostly relevant to Secret Free VMs. Signed-off-by: Nikita Kalyazin <[email protected]>
kalyazin
force-pushed
the
kill_fault_all
branch
from
5775fb4 to
84c4313
Compare
kalyazin
changed the title
kalyazin
changed the title
|
We can't do that for functional and security reasons, see the comment for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not store UFFD handle in VMM. The UFFD object gets dropped as soon as the last reference to it (in the handler) goes away.
Reason
This is required to make sure no further UFFD messages will be sent to the handler that is no longer available to avoid an infinite lockup.
This is relevant for Secret Free VMs, because the UFFD handler uses
writeinstead ofUFFDIO_COPYto prepopulate guest memory and is not required to preinstall userspace page tables while doing it.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] I have runtools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
[ ] I have mentioned all user-facing changes inCHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
[ ] I have tested all new and changed functionalities in unit tests and/orintegration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.