Skip to content

Add building with Podman managed containers #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add building with Podman managed containers #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
firectl
firectl.sha256
.vscode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For editor-specific files, I think it would be better to use a per-user global gitignore file.

https://help.github.com/en/github/using-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ endif
build-in-docker:
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.12 make

build-in-podman:
podman run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.12 make

test:
go test -v ./...

Expand Down
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ installed on your computer.
_We use [go modules](https://github.com/golang/go/wiki/Modules), so you need to
build with Go 1.11 or newer._

If you do not have a new-enough Go toolchain installed, you can use `make
build-in-docker`. This rule creates a temporary Docker container which builds
and copies the binary to your current directory.
If you do not have a new-enough Go toolchain installed, you can build in a
temporary container - the binary is copied to your current directory:

1. `make build-in-docker`
1. `make build-in-podman`
Comment on lines +22 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using * instead? People may see the instruction as "First make build-in-docker, then make build-in-podman", but the intention here is OR, not AND.

* `make build-in-docker`
* `make build-in-podman`

Copy link
Author

@bbros-dev bbros-dev Apr 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point:

*  `make build-in-docker`, or
*  `make build-in-podman`


Usage
---
Expand Down