Use xctrace on macOS #374
Merged
Use xctrace on macOS #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Apr 28, 2025
|
Thanks! |
|
Released 0.6.8 with this change -- see the release notes. |
Closed
corneliusroemer
added a commit
to corneliusroemer/flamegraph
that referenced
this pull request
May 2, 2025
Root/sudo is no longer required on macOS since flamegraph-rs#374 was merged. Hence, the section of the README that explained why that was necessary can be removed.
This was referenced May 2, 2025
Closed
djc
pushed a commit
that referenced
this pull request
May 3, 2025
Root/sudo is no longer required on macOS since #374 was merged. Hence, the section of the README that explained why that was necessary can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just @ldm0's PR #368 with a small fix to let it build on windows targets