Skip to content

Conversation

Watson1978
Copy link
Contributor

This patch will fix following error when run test:

$ bundle exec rake
/home/watson/.rbenv/versions/3.3.9/bin/ruby -w -I"lib:lib:test" /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/plugin/test_in_fluent_package_update_notifier.rb"
/home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:36:in `block in included': undefined method `setup' for class Test::Unit::TestCase (NoMethodError)

            setup :before => :prepend
            ^^^^^
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:35:in `module_eval'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:35:in `included'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:110:in `include'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:110:in `<class:TestCase>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:109:in `<module:Unit>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:24:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/src/fluent-plugin-fluent-package-update-notifier/test/helper.rb:2:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/src/fluent-plugin-fluent-package-update-notifier/test/plugin/test_in_fluent_package_update_notifier.rb:1:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:21:in `block in <main>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `select'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test" /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/plugin/test_in_fluent_package_update_notifier.rb" ]
/home/watson/.rbenv/versions/3.3.9/bin/bundle:25:in `load'
/home/watson/.rbenv/versions/3.3.9/bin/bundle:25:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

This patch will fix following error when run test:

```
$ bundle exec rake
/home/watson/.rbenv/versions/3.3.9/bin/ruby -w -I"lib:lib:test" /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/plugin/test_in_fluent_package_update_notifier.rb"
/home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:36:in `block in included': undefined method `setup' for class Test::Unit::TestCase (NoMethodError)

            setup :before => :prepend
            ^^^^^
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:35:in `module_eval'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:35:in `included'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:110:in `include'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:110:in `<class:TestCase>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:109:in `<module:Unit>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/test-unit-rr-1.0.5/lib/test/unit/rr.rb:24:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/src/fluent-plugin-fluent-package-update-notifier/test/helper.rb:2:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/src/fluent-plugin-fluent-package-update-notifier/test/plugin/test_in_fluent_package_update_notifier.rb:1:in `<top (required)>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:21:in `block in <main>'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `select'
        from /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test" /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/plugin/test_in_fluent_package_update_notifier.rb" ]
/home/watson/.rbenv/versions/3.3.9/bin/bundle:25:in `load'
/home/watson/.rbenv/versions/3.3.9/bin/bundle:25:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
```
@Watson1978 Watson1978 changed the title helper: fix require ci: fix require Aug 18, 2025
@Watson1978 Watson1978 requested a review from kenhys August 18, 2025 02:29
@daipom
Copy link
Contributor

daipom commented Aug 18, 2025

Thanks!
But it looks to me that the cause of the current CI failure is the version of test-unit and test-unit-rr.
Is it reasonable to change to use test/unit?

@daipom daipom mentioned this pull request Aug 18, 2025
@daipom
Copy link
Contributor

daipom commented Aug 18, 2025

It appears that the current CI failure is caused by test-unit 3.6.9 (see test-unit/test-unit#320).
If there is no positive reason for using test/unit, how about fixing it like #2?

@Watson1978 Watson1978 closed this Aug 18, 2025
@Watson1978 Watson1978 deleted the fix branch August 18, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants