-
Notifications
You must be signed in to change notification settings - Fork 1.7k
plugins: fix compilation if FLB_SQLDB (sqlite3) is disabled #10239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
plugins: fix compilation if FLB_SQLDB (sqlite3) is disabled #10239
Conversation
4b2f2ad
to
a767a54
Compare
Let's make sure this compiles for all existing targets as well. Would it be better to disable the features within the plugins that need the DB rather than the whole plugin @leonardo-albertovich ? It feels a bit like a large hammer, e.g. no tail input even if you don't use db. We would have to make the config options and any other usage conditional though so it may be worse. |
How can it not? Currently, FLB_SQLDB is enabled by default, and will stay like that. The problem is the other way around, if not enabled, then compilation breaks.
For me fine, but I would do that on a per feature basis. Perhaps just continue with this PR, and then fine-tune some features that might compile with some small fixups. In general, it would be much better if all options are toggled in the automated tests, on one reference compilation system. Perhaps even by incremental builds. But either way, I just want to fix compilation now. |
a767a54
to
8cf7987
Compare
Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Thomas Devoogdt <[email protected]>
8cf7987
to
7092bc1
Compare
@patrick-stephens @edsiper I changed this PR so that plugins are still compiled, but without database support. I hope this answers #10239 (comment). Tested by doing this:
and
|
Not sure if the CI failure is relevant or something else |
I just added |
Fixes: