-
Notifications
You must be signed in to change notification settings - Fork 60
DVR #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
DVR #68
Changes from 21 commits
518a325
ab9d3ca
258e9a2
8aed123
7e3a4f8
98457fe
e519abd
806e25a
556beb6
2f703fe
879ddb1
2fb45ad
5b29b5e
42d04b9
f2bc27e
e31693c
252f91d
45a38cc
4efb67c
e0b6c7f
60cb09b
c99dd7c
b04bc43
f44645b
6f17c81
6710312
46280c6
ff5dc68
4f6d55c
b481180
c5ef237
70d41c9
e4af1f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,13 +4,19 @@ | |
package="com.fpvout.digiview"> | ||
|
||
<uses-feature android:name="android.hardware.usb.host" /> | ||
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | ||
<uses-permission android:name="android.permission.RECORD_AUDIO"/> | ||
<uses-permission android:name="android.permission.CAMERA"/> | ||
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> | ||
<uses-permission android:name="android.permission.WAKE_LOCK" /> | ||
|
||
<application | ||
android:allowBackup="false" | ||
android:icon="@mipmap/ic_launcher" | ||
android:label="@string/app_name" | ||
android:roundIcon="@mipmap/ic_launcher_round" | ||
android:largeHeap="true" | ||
android:requestLegacyExternalStorage="true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be best to use scoped storage and shared directories : There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mhh i know bad habit to use the old implementation ;-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for backwards compatibility I leave it as it is. we can change it later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better change it before a release/merge: WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 11 - even with 'android:requestLegacyExternalStorage'. Sdk level 11+ is required for updates starting November 2021. This could delay feature/bugfix rollouts until the dvr is reworked. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok good to know! i will update that |
||
android:supportsRtl="true" | ||
android:theme="@style/Theme.Digiview" | ||
> | ||
|
Uh oh!
There was an error while loading. Please reload this page.