Skip to content

Fix MediaGallery to display selected variant images #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions app/components/product/MediaGallery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ import {
CarouselItem,
} from '../ui/Carousel';

import {useProductVariants} from '~/hooks/useProductVariants';
import {useSelectedVariant} from '~/hooks/useSelectedVariant';

type Media =
| Media_ExternalVideo_Fragment
| Media_MediaImage_Fragment
Expand All @@ -36,9 +39,26 @@ export function MediaGallery(props: {aspectRatio?: AspectRatioData}) {
const medias = product?.media?.nodes.length
? flattenConnection(product.media)
: [];
const {variants} = useProductVariants();
const selectedVariant = useSelectedVariant({variants});
const variantMedias = selectedVariant?.images?.length
? flattenConnection(selectedVariant.images)
: [];
const combinedMedias = [...variantMedias, ...medias];
const uniqueMedias = combinedMedias.filter(
(media, index, self) =>
index ===
self.findIndex(
(m) =>
m.__typename === 'MediaImage' &&
media.__typename === 'MediaImage' &&
m.image.url === media.image.url,
),
);
const [activeMediaId, setActiveMediaId] = useState<null | string>(null);
const selectedImage =
medias.find((media) => media?.id === activeMediaId) || medias[0];
uniqueMedias.find((media) => media?.id === activeMediaId) ||
uniqueMedias[0];

if (!selectedImage) return null;

Expand All @@ -47,9 +67,9 @@ export function MediaGallery(props: {aspectRatio?: AspectRatioData}) {
<div className="hidden lg:block">
<MainMedia aspectRatio={props.aspectRatio} media={selectedImage} />
</div>
<MobileCarousel aspectRatio={props.aspectRatio} medias={medias} />
<MobileCarousel aspectRatio={props.aspectRatio} medias={uniqueMedias} />
<ThumbnailCarousel
medias={medias}
medias={uniqueMedias}
selectedImage={selectedImage}
setActiveMediaId={setActiveMediaId}
/>
Expand Down
5 changes: 4 additions & 1 deletion app/hooks/useSelectedVariant.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,8 @@ export function useSelectedVariant(props: {
return firstAvailableVariant ?? firstVariantFound;
}

return selectedVariant;
return {
...selectedVariant,
images: selectedVariant?.images || [],
};
}