Skip to content

Add ability to pass options to addEventListener in from-event #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/beicon/v2/core.cljs
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,13 @@
(fn [] (remove-watch atm key)))))))

(defn from-event
"Creates an Observable by attaching an event listener to an event target"
[et ev]
(rx/fromEvent et ev))
"Creates an Observable by attaching an event listener to an event target
Args:
et: the event target (e.g., a DOM element or window)
ev: the event type (e.g., 'click', 'mousemove')
opts: optional options for the event listener (e.g., {passive: true})"
([et ev & [opts]]
(rx/fromEvent et ev (clj->js (or opts {})))))

(def ^function timer
"Returns an observable sequence that produces a value after
Expand Down
12 changes: 12 additions & 0 deletions test/beicon/tests/v2_test.cljs
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,18 @@
(t/is (= % ["once"]))
(done)))))))

(t/deftest observable-from-event-args
(t/async done
(let [target #js {:addEventListener (fn [type listener opts]
(t/is (= type "poked"))
(listener (.-passive opts)))
:removeEventListener #()}
s (rx/from-event target "poked" {:passive false})]
(t/is (rx/observable? s))
(rx/end! (drain! s #(do
(t/is (= % [false]))
(done)))))))

(t/deftest observable-with-timeout
(t/async done
(let [s (->> (rx/timer 200)
Expand Down