-
Notifications
You must be signed in to change notification settings - Fork 11
Disable CLI11 vendoring by default #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Steve Peters <[email protected]>
we may need to update the package metadata to ensure the |
it's missing from both noble and homebrew, though homebrew doesn't report cmake warnings so its build status looks fine |
Signed-off-by: Steve Peters <[email protected]>
updated metadata for homebrew in osrf/homebrew-simulation#2928 and Ubuntu in 6e8fead the windows metadata still needs to be updated |
Signed-off-by: Steve Peters <[email protected]>
Needed by gazebosim/gz-utils#167. Signed-off-by: Steve Peters <[email protected]>
adding I'm not sure what to do for conda (cc @traversaro) |
At the conda-forge level, |
Perhaps we need to add |
I've hijacked gazebo-tooling/release-tools#1230 to include the conda update. |
thanks! I'll mark this ready for review once we've merged gazebo-tooling/release-tools#1230 |
* Needed by gazebosim/gz-utils#167. * Add conda-forge cli11 pixi-2.1.2 Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
@osrf-jenkins run tests please |
1 similar comment
@osrf-jenkins run tests please |
this is ready for review |
Support is not found in Windows.
|
can you take a look at gazebo-tooling/release-tools#1307? |
@osrf-jenkins run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working, thanks for the fix!
Signed-off-by: Steve Peters <[email protected]>
I updated the migration guide in a4d96d6 |
🦟 Bug fix
Part of #135
Summary
CLI11 is available upstream, so don't vendor by default.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.