Restore vendoring of cli11 by default #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to workaround a bug in cli11 2.4.2 and gz-sim-model. Signed-off-by: Steve Peters <[email protected]>
iche033
approved these changes
May 21, 2025
scpeters
added a commit
that referenced
this pull request
May 23, 2025
This reverts commit bdcef68. Signed-off-by: Steve Peters <[email protected]>
This was referenced May 23, 2025
scpeters
added a commit
that referenced
this pull request
May 29, 2025
Revert "Restore vendoring of cli11 by default (#178)" This reverts commit bdcef68. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Workaround for gazebosim/gz-sim#2918
Summary
Needed to workaround a bug in cli11 2.4.2 and gz-sim-model.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.