-
Notifications
You must be signed in to change notification settings - Fork 53
Update disk image source to addhypercall
and gem5bridge-driver
#69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Conversation
- This commit updates the serial-getty service file to override only the service section with autologin instead of the entire file.
- This change should speed up boot time that is caused in gem5 due to low system entropy
- Update comments explaining the reason for increasing entropy
I have updated source for the NPB disk image to use hypercalls. I tested the NPB disk images on the staging branch for release 24.1.1. I was able to successfully run NPB benchmarks without using |
TODO: I need to changes the link and the |
src/ubuntu-generic-diskimages/kernel-and-modules/arm-ubuntu-22.04/Dockerfile
Outdated
Show resolved
Hide resolved
src/ubuntu-generic-diskimages/kernel-and-modules/arm-ubuntu-22.04/Dockerfile
Outdated
Show resolved
Hide resolved
src/ubuntu-generic-diskimages/kernel-and-modules/arm-ubuntu-24.04/Dockerfile
Outdated
Show resolved
Hide resolved
--file "$DOCKERFILE" \ | ||
--output "$OUTPUT" . | ||
|
||
echo "Build completed for $1: Output directory is $OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, this message is printed even if the build fails. It would be nice if a different message could be printed for a failure, but it's not high priority.
--file "$DOCKERFILE" \ | ||
--output "$OUTPUT" . | ||
|
||
echo "Build completed for $1: Output directory is $OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, this message is printed even if the build fails. It would be nice if a different message could be printed for a failure, but it's not high priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Build completed for $1: Output directory is $OUTPUT" | |
if [ $? -eq 0]; | |
then | |
echo "Build completed for $1: Output directory is $OUTPUT" | |
else | |
echo "Build failed for $1" | |
fi |
This message could be modified to print different messages based on build failure/success. I haven't tested this code snippet, so please test it if you want to incorporate it into the script
} | ||
``` | ||
``` | ||
|
||
If you need to increase the size of the image when adding more libraries and files to the image update the size of the partition in the respective `http/*/user-data` file. Also, update the `disk_size` parameter in `post-installation.sh` to be at least one mega byte more than the size you defined in the `user-data` file. | ||
|
||
**NOTE:** You can extend this disk image by modifying the `post-installation.sh` script, but it requires building the image from scratch. | ||
|
||
To take a pre-built image and add new files or packages, take a look at the following [documentation](https://www.gem5.org/documentation/gem5-stdlib/extending-disk-images). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link appears to be broken
6559de6
to
b6830ca
Compare
b6830ca
to
819ed59
Compare
--file "$DOCKERFILE" \ | ||
--output "$OUTPUT" . | ||
|
||
echo "Build completed for $1: Output directory is $OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Build completed for $1: Output directory is $OUTPUT" | |
if [ $? -eq 0]; | |
then | |
echo "Build completed for $1: Output directory is $OUTPUT" | |
else | |
echo "Build failed for $1" | |
fi |
This message could be modified to print different messages based on build failure/success. I haven't tested this code snippet, so please test it if you want to incorporate it into the script
--file "$DOCKERFILE" \ | ||
--output "$OUTPUT" . | ||
|
||
echo "Build completed for $1: Output directory is $OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Build completed for $1: Output directory is $OUTPUT" | |
if [ $? -eq 0]; | |
then | |
echo "Build completed for $1: Output directory is $OUTPUT" | |
else | |
echo "Build failed for $1" | |
fi |
This message could be modified to print different messages based on build failure/success. I haven't tested this code snippet, so please test it if you want to incorporate it into the script
No description provided.