Skip to content

#10982 Side panels should be smaller #11009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Apr 11, 2025

Description

This PR reduces sizes of right panels to 420px.

This include also the Details panel in addition to panels listed in the issue

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#10982

What is the new behavior?

Reduced width of right side panel to 420px

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Apr 11, 2025
@allyoucanmap allyoucanmap added this to the 2025.01.00 milestone Apr 11, 2025
@allyoucanmap allyoucanmap self-assigned this Apr 11, 2025
@allyoucanmap allyoucanmap linked an issue Apr 11, 2025 that may be closed by this pull request
6 tasks
@tdipisa tdipisa requested a review from MV88 April 11, 2025 12:41
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good generally speaking, but in one case we have to handle the space available better, not sure if we have to redesign some parts. I've added also some other thoughts

  • is worth to include this change in the migration guidelines as a suggestion to check custom code that rely on side panels that are reusing core components?
  • since we repeat 420 everywhere I would create a single constant DEFAULT_RIGHT_PANEL_SIZE or DEFAULT_PANEL_WIDTH somewhere in the utils or we could create a constants.js file that will be used for the core part of mapstore, it can be placed in utils folder

  • in feature info in case of aeronautical option the buttons misaligns

with editor opened
image

with editor closed (this was also present before, but since we are here...)
image

DEV with editor opened
image

DEV with editor closed
image


@allyoucanmap allyoucanmap requested a review from MV88 April 30, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side panels should be smaller
2 participants