fix: sort onchain transactions by createdAt #1407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-adithya I don't think this should be done on the frontend especially if we add paging later. Can it be fixed in LND? LDK is already sorted correctly |
|
Ah true, I'll try to fix this in LND backend 👍 |
|
Hmmm weird, we already do the sorting in the backend (for both lnd/ldk), I remember seeing some anomaly in the list. Maybe it was "Pending" transactions being listed in between sent/receive txs, should we show those pending ones on top? Edit: Yes, but this isn't a sorting problem, it is a confirmed tx which is being shown as pending, I'll to see if we can fix somehow 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the onchain txs are not in sorted order (noticed in LND), this fixes that.