Plan-v5 #90
Merged
Plan-v5 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restructures protobuf definitions, API endpoints, and corresponding test cases to align with a new naming and directory structure.
- Updated protobuf file paths and renamed fields in PaymentProviders and PaymentMethod.
- Updated API endpoint from "/plans-v4" to "/plans-v5".
- Adjusted tests and Makefile to reflect the new structure.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| api/protos/vpn.proto | Renamed field logoUrls to icons and changed PaymentMethod.providers to a singular provider. |
| api/protos/vpn.pb.go | Updated generated code to reflect new proto paths and field changes. |
| api/protos/response.go | Removed the obsolete Logo field from the PlansResponse structure. |
| api/pro_test.go | Added a test assertion to verify that the Plans field is not nil. |
| api/pro_api.go | Updated API endpoint from "/plans-v4" to "/plans-v5". |
| Makefile | Modified protobuf generation commands to use the new proto file paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the protobuf files, API endpoints, and related code to align with a new structure and naming conventions. The changes involve renaming and restructuring protobuf files, updating API routes, and modifying test cases and data models to reflect the new structure.
Protobuf and API Updates:
user/protostoapi/protosin theMakefileand generated Go files. This includes changes toauth.protoandvpn.prototo reflect the new directory structure. [1] [2]LogoUrlswithIconsinPaymentProvidersand changingProviderstoProviderinPaymentMethod. [1] [2]API Endpoint Changes:
/plans-v4to/plans-v5in thePlansmethod ofpro_api.go.Data Model and Test Updates:
Logofield from thePlansResponsestruct inresponse.goand ensured thePlansfield is not nil in theTestPlanstest case. [1] [2]These changes collectively improve the organization of the codebase and align it with the updated API and protobuf structure.