Update Maven Publish Plugin #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
requested review from
markushi,
romtsn,
adinauer,
stefanosiano and
lcian
as code owners
|
hm, the artifacts check is failing - could you verify why? I can't grasp from the build job logs what's missing https://github.com/getsentry/sentry-android-gradle-plugin/actions/runs/15455714004/job/43507512990?pr=902 |
This updates the Maven Publish Plugin which should unblock enabling the configuration cache and also help with updating to Gradle 8.x in this repo. The changelog for all the versions is here: https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md#version-0180-2021-09-13 Note, we cannot update to a higher version until the build itself is build with Gradle 8.x or higher. The api to configure signing was changed in 0.20.0 this is why the gradle property was adjusted.
runningcode
force-pushed
the
no/update-maven-publish-plugin
branch
from
7f28261 to
69cf8ec
Compare
runningcode
force-pushed
the
no/update-maven-publish-plugin
branch
from
69cf8ec to
a932f07
Compare
runningcode
commented
Jun 5, 2025
| @@ -49,7 +49,7 @@ jobs: | |||
| - name: Verify artifact contents | |||
| shell: bash | |||
| run: | | |||
| zipfile=$(ls -1 plugin-build/build/distributions | grep -v "PluginMarker") | |||
| zipfile=$(ls -1 plugin-build/build/distributions | grep -v "PluginMarker" | grep -v ".tar") | |||
There was a problem hiding this comment.
@romtsn seems there is now an additional .tar artifact which is built since we call assemble which assembles everything. i just filtered it out here.
runningcode
commented
Jun 5, 2025
| @@ -226,7 +225,7 @@ distributions { | |||
| main { | |||
| contents { | |||
| from("build${sep}libs") | |||
| from("build${sep}publications${sep}maven") | |||
| from("build${sep}publications${sep}pluginMaven") | |||
There was a problem hiding this comment.
@romtsn figured it out. we were grabbing the maven publication from the wrong folder and that wrong folder was removed in the update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This updates the Maven Publish Plugin which should unblock enabling the
configuration cache and also help with updating to Gradle 8.x in this
repo.
The changelog for all the versions is here: https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md#version-0180-2021-09-13
Note, we cannot update to a higher version until the build itself is
build with Gradle 8.x or higher.
The api to configure signing was changed in 0.20.0 this is why the
gradle property was adjusted.
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps