feat(logs): support log streaming #2666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrozdanic
force-pushed
the
vg/log-streaming
branch
from
93b8792 to
90ba3c8
Compare
vgrozdanic
commented
Aug 1, 2025
| } | ||
|
|
||
| // Maintain buffer size limit by removing oldest entries | ||
| while self.buffer.len() > self.max_size { |
There was a problem hiding this comment.
this is done to prevent OOM in case this keeps running for a long time
vgrozdanic
force-pushed
the
vg/log-streaming
branch
from
90ba3c8 to
44a987b
Compare
Signed-off-by: Vjeran Grozdanic <[email protected]>
vgrozdanic
force-pushed
the
vg/log-streaming
branch
from
44a987b to
d18413f
Compare
vgrozdanic
commented
Aug 1, 2025
Comment on lines
+128
to
+131
| format.separator( | ||
| prettytable::format::LinePosition::Title, | ||
| prettytable::format::LineSeparator::new('-', '+', '+', '+'), | ||
| ); |
There was a problem hiding this comment.
We need to do custom formatting, because every other formatting adds empty lines after printing out the table. We want it to seem like it's infinite table, without empty lines in between printing multiple rows, so we need to use FORMAT_NO_BORDER, and define our own line separator for header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for live streaming of logs by polling the API every 2 seconds (by default).
Polling interval is configurable via command line argument.
In order to show streamed logs as a table, it implements new methods on Table struct:
print_table_start- this prints both the header and the first few rows (as many as it was fetched in the first API call). This combines two operations because if we would only print header without any rows, than the table would look weirdly formatted, since the header doesn't know how wide it should be without any data in it. This method prints the table without the bottom border.print_rows_only- Prints only the rows in the table, without the header, and without the bottom and upper border