feat(launchpad): Add asset catalog files to zip without adding to folder #2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
force-pushed
the
addAssetsToZip
branch
3 times, most recently
from
2a8c8f5 to
5f58d61
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
noahsmartin
force-pushed
the
addAssetsToZip
branch
from
5f58d61 to
7f81494
Compare
noahsmartin
force-pushed
the
addAssetsToZip
branch
from
7f81494 to
747a231
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Left some questions and comments. While the PR description makes sense at a high level, I am generally a bit confused about what is meant to be changing behavior-wise here. I also don't see where the IPA file changes are happening – as this issue sounds separate based on your PR description; I would appreciate if the relevant changes for the IPA issue could be split off from the rest of the PR
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
noahsmartin
force-pushed
the
addAssetsToZip
branch
from
c25b132 to
caab2c2
Compare
noahsmartin
changed the base branch from
master
to
ryan/fix_latest_clippy_lints
noahsmartin
force-pushed
the
addAssetsToZip
branch
2 times, most recently
from
c31d8b5 to
483bdb0
Compare
noahsmartin
force-pushed
the
addAssetsToZip
branch
from
483bdb0 to
b6efd40
Compare
szokeasaurusrex
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the app upload experience by making it so assets are written directly to the zip file rather than to the input xcarchive directory. Previously the assets were written to the input folder and then all the files in the folder were zipped. This meant the original location the user passed to the CLI had extra files in it after running the command, which is confusing.
There was also a bug that assets were not handled for ipa uploads. IPA files are already zipped, so when we wrote assets to the user's input directory we only did that for xcarchives (Which is a directory not a zip file). So a side effect of not writing images to the users input directory was also to fix this issue for IPAs, and now IPA uploads have assets included too.