fix(dashboards): Starred dashboards not changing in navbar #90338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
👍🏻 LGTM!
I think this could be followed with a small refactor:
updateDashboardFavoritecould use theuseMutationhook from TanStack Query (there are a bunch of examples of this floating around the codebase) which is a more up-to-date way of doing this kind of thing- a successful mutation shouldn't invalidate the whole cache, I think you can use the
setApiQueryDatahelper to update the cache. This way the page won't need to do a full re-fetch of the dashboard data
If neither of those suggestions actually makes sense you can ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, starring a dashboard on the manage dashboards page would show changes in the nav bar but if it was favourited anywhere else it would not. I've moved the logic to clear the api query cache to the
updateDashboardFavoritefunction so that the cache is cleared every time a favourite dashboard is updated. As long as this function is being used to update the favourites, the navbar will show the changes. (This function is being used to update favourites in all places afaik)