Skip to content

feat(taskworker): Make ingest errors taskworker compatible #90340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 1, 2025

Conversation

enochtangg
Copy link
Member

This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this document.

@enochtangg enochtangg requested review from a team as code owners April 24, 2025 20:54
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90340      +/-   ##
==========================================
- Coverage   87.78%   85.22%   -2.56%     
==========================================
  Files       10276    10288      +12     
  Lines      582704   583825    +1121     
  Branches    22567    22658      +91     
==========================================
- Hits       511543   497584   -13959     
- Misses      70732    85695   +14963     
- Partials      429      546     +117     

Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these tasks have untyped parameters (in some cases just **kwargs). I think we should do some extra auditing to try and ensure that all the parameters these functions are called with can be serialized to JSON.

@enochtangg
Copy link
Member Author

@evanh Just did an audit. It looks like post_process_group is the only task that calls with kwargs. Its parameters are safe to serialize with JSON

@@ -1508,6 +1509,14 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
},
}

#
TASKWORKER_ENABLE_INGEST_NAMESPACES = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I wouldn't name this INGEST, I think this is a concept we could use for other namespaces besides ingest that receive high traffic.

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the extra settings will help prevent another option problem.

@enochtangg enochtangg merged commit 81c13d4 into master May 1, 2025
59 checks passed
@enochtangg enochtangg deleted the migrate-ingest-errors-taskworker branch May 1, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants