Skip to content

fix(ui): Improve padding for [beta] tag #90344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

fix(ui): Improve padding for [beta] tag #90344

merged 3 commits into from
Apr 25, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented Apr 24, 2025

Add additional styling to anomaly detection FeatureBadges to space them out from and better align them with adjacent text.

Screenshots after:
Screenshot 2025-04-24 at 2 46 24 PM
Screenshot 2025-04-24 at 2 46 41 PM

Fixes ISWF-363

@kcons kcons requested a review from a team as a code owner April 24, 2025 22:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 24, 2025
@kcons kcons requested a review from mifu67 April 24, 2025 22:11
Copy link

codecov bot commented Apr 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10313 1 10312 5
View the top 1 failed test(s) by shortest run time
Performance > Transaction Summary > Transaction Events > Index should contain all transaction events
Stack Traces | 1.43s run time
Error: Unable to find an element with the text: uhoh@example.com. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../transactionSummary/transactionEvents/index.spec.tsx:161:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@kcons
Copy link
Member Author

kcons commented Apr 24, 2025

There's certainly an argument for 0.5 (or even 1) rather than 0.25; I looked at other uses and that seemed a fairly common choice and erring toward adding as little extra space as necessary to make it not look wrong seemed sensible.

@mifu67
Copy link
Contributor

mifu67 commented Apr 25, 2025

Looks good—could you add a screenshot?

@mifu67 mifu67 requested a review from ameliahsu April 25, 2025 16:52
@kcons kcons merged commit 6d2ffe5 into master Apr 25, 2025
45 checks passed
@kcons kcons deleted the kylec/fix-padding branch April 25, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants