Skip to content

Feat(jira-server): Adds new tabs for user-mapping integration feature #90346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GabeVillalobos
Copy link
Member

@GabeVillalobos GabeVillalobos commented Apr 24, 2025

UI changes for #90026

Changes

  • Adds handling for user-mapping integration feature, which renders the User Mapping tab, along with a main Settings tab
  • Minor refactors for tab rendering for stacktrace-link and codeowners features.

Screenshots

Settings Tab

Screenshot 2025-04-24 at 2 42 56 PM

User Mappings Tab

Screenshot 2025-04-24 at 3 03 06 PM

Stacktrace Linking Integration [No Visual Changes]

Screenshot 2025-04-24 at 2 42 36 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 24, 2025
@GabeVillalobos GabeVillalobos requested a review from a team April 24, 2025 22:15
Comment on lines +477 to +479
if (allTabs.length === 0) {
return renderMainTab();
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to the bottom and made it the default if no other tabs are available to render vs short-circuiting.

// and code owners, so only render the main settings tab and user mappings.
const userMappingTabs: Array<[Tab, string]> = hasUserMapping
? [
['repos', t('Settings')],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little quirky, but the main "settings" tab is called repos in the UI

@GabeVillalobos GabeVillalobos changed the title Feat(jira-server): Adds new tabs for user-mapping integraiton feature Feat(jira-server): Adds new tabs for user-mapping integration feature Apr 28, 2025
@GabeVillalobos GabeVillalobos marked this pull request as ready for review April 28, 2025 16:30
Copy link
Contributor

@Christinarlong Christinarlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, append tabs based on type of integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants