-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(issue summary): Add locking mechanism #90347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #90347 +/- ##
==========================================
- Coverage 87.78% 87.41% -0.37%
==========================================
Files 10264 10273 +9
Lines 580241 585145 +4904
Branches 22635 22659 +24
==========================================
+ Hits 509346 511504 +2158
- Misses 70460 73203 +2743
- Partials 435 438 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the comments not making sense, seems reasonble to me.
Have you tested this extensively locally? Just want to make sure to not cause an issue summary INC...
@jennmueng fixed the comments and made it a bit more readable My testing is:
idk if that's enough 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say just making sure the locking mechanism works locally should suffice.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
If a summary is in progress for an issue while another request comes in, the other request should wait for a bit first. This ensures only one call to Seer per issue at a time.