Skip to content

fix(eap): Has parent span filter #90348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

Zylphrex
Copy link
Member

This fixes the has:parent_span and !has:parent_span filters on eap spans.

This fixes the has:parent_span and !has:parent_span filters on eap spans.
@Zylphrex Zylphrex requested a review from a team as a code owner April 24, 2025 22:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 24, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/search/eap/columns.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90348       +/-   ##
===========================================
+ Coverage   32.96%   87.81%   +54.84%     
===========================================
  Files        8695    10259     +1564     
  Lines      483493   579331    +95838     
  Branches    22647    22647               
===========================================
+ Hits       159396   508740   +349344     
+ Misses     323653    70147   -253506     
  Partials      444      444               

@Zylphrex Zylphrex merged commit f0d2fbe into master Apr 25, 2025
65 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/has-parent-span-filter branch April 25, 2025 13:36
evanh pushed a commit that referenced this pull request Apr 25, 2025
This fixes the has:parent_span and !has:parent_span filters on eap
spans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants