feat(dynamic-sampling): add explanatory message on settings page for orgs that don't have dynamic sampling or custom sample rates #90358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shellmayr
commented
Apr 25, 2025
•
shellmayr
commented
- Add a message when Dynamic Sampling is not available at all, pointing users to documentation
- Add a message when Dynamic Sampling is available, but not Custom Sample Rates, pointing users to documentation about Sampling Priorities
| Org Type | Before | After |
|---|---|---|
| No Dynamic Sampling |  |
 |
| Only Sampling Priorities |  |
 |
…orgs that don't have dynamic sampling or custom sample rates
github-actions
bot
added
the
Scope: Frontend
…namic-sampling-settings-page
| !hasDynamicSamplingCustomFeature(organization) | ||
| ) { | ||
| return ( | ||
| <Alert.Container> |
There was a problem hiding this comment.
we probably do not need the container, since there is no element below the alert
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90358 +/- ##
==========================================
- Coverage 87.86% 87.82% -0.05%
==========================================
Files 10276 10270 -6
Lines 581600 579632 -1968
Branches 22633 22633
==========================================
- Hits 511046 509034 -2012
- Misses 70120 70164 +44
Partials 434 434 |
ArthurKnaus
approved these changes
Apr 28, 2025
shellmayr
deleted the
shellmayr/tet-331-add-plan-detection-to-dynamic-sampling-settings-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.