ref(✂️): remove unused experiment code #90359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
static/app/types/experiments.tsx
Outdated
There was a problem hiding this comment.
Can the whole file be blown away?
There was a problem hiding this comment.
experiments are still part of the organization type:
sentry/static/app/types/organization.tsx
Line 67 in 13941e1
if you’re sure they aren’t needed, I can try to remove them too
There was a problem hiding this comment.
ooh look at this: I can remove it from organization and user types and didn’t get any errors, so it’s really unused. More removal happened here: 8225ae9
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90359 +/- ##
===========================================
+ Coverage 46.37% 83.15% +36.77%
===========================================
Files 10267 10280 +13
Lines 578880 579244 +364
Branches 22650 22659 +9
===========================================
+ Hits 268468 481667 +213199
+ Misses 309984 97138 -212846
- Partials 428 439 +11 |
evanpurkhiser
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.