Skip to content

ref(✂️): remove unused Component Hooks #90360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Apr 25, 2025

These two hooks were registered:

'component:profiling-upgrade-plan-button': () => ProfilingUpgradePlanButton,
'component:profiling-am1-or-mmx-upgrade': () => ProfilingAM1OrMMXUpgrade,

but the hook itself was never consumed anywhere in the application, which means it can’t show up in the UI. So this PR removes those hooks and the associated components.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 25, 2025
@TkDodo TkDodo marked this pull request as ready for review April 25, 2025 09:55
@TkDodo TkDodo requested a review from a team as a code owner April 25, 2025 09:55
@TkDodo TkDodo requested a review from JonasBa April 25, 2025 09:55
@TkDodo
Copy link
Contributor Author

TkDodo commented Apr 25, 2025

/cc @JonasBa looking at the history, I think you originally added those two component hooks

@TkDodo TkDodo merged commit 447dba0 into master Apr 25, 2025
46 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/remove-unused-component-hooks branch April 25, 2025 14:22
evanh pushed a commit that referenced this pull request Apr 25, 2025
These two hooks were registered:

```
'component:profiling-upgrade-plan-button': () => ProfilingUpgradePlanButton,
'component:profiling-am1-or-mmx-upgrade': () => ProfilingAM1OrMMXUpgrade,
```

but the hook itself was never consumed anywhere in the application,
which means it can’t show up in the UI. So this PR removes those hooks
and the associated components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants