-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(issues): Debug FIle Candidates: Adjust layout for buttons #94841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): Debug FIle Candidates: Adjust layout for buttons #94841
Conversation
Co-authored-by: bruno <[email protected]>
do I only get the vercel preview if I make this non draft? |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94841 +/- ##
==========================================
+ Coverage 87.82% 87.89% +0.06%
==========================================
Files 10479 10442 -37
Lines 605756 603114 -2642
Branches 23671 23493 -178
==========================================
- Hits 532027 530105 -1922
+ Misses 73365 72640 -725
- Partials 364 369 +5 |
Test failures seem like flakes:
|
re-ran them, look passing now |
static/app/components/events/interfaces/debugMeta/debugImageDetails/candidates.tsx
Outdated
Show resolved
Hide resolved
…tails/candidates.tsx
the scroll bar being visible is a user setting. This is what it looks like for me on prod i think there's some widths here where its overflowing from the current changes you could also try setting the modal width to 100vw or something https://github.com/getsentry/sentry/blob/master/static/app/components/events/interfaces/debugMeta/debugImageDetails/index.tsx#L371-L381 |
beyond my or cursors skill at this problem so I'll give up |
With the viewport relatively small, the buttons are hidden and with no indicattion that they exist since no scroll bar is visible: