Skip to content

feat(issues): Debug FIle Candidates: Adjust layout for buttons #94841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bruno-garcia
Copy link
Member

With the viewport relatively small, the buttons are hidden and with no indicattion that they exist since no scroll bar is visible:

image
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 3, 2025
@bruno-garcia
Copy link
Member Author

do I only get the vercel preview if I make this non draft?

@bruno-garcia bruno-garcia marked this pull request as ready for review July 10, 2025 20:44
@bruno-garcia bruno-garcia requested a review from a team as a code owner July 10, 2025 20:44
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #94841      +/-   ##
==========================================
+ Coverage   87.82%   87.89%   +0.06%     
==========================================
  Files       10479    10442      -37     
  Lines      605756   603114    -2642     
  Branches    23671    23493     -178     
==========================================
- Hits       532027   530105    -1922     
+ Misses      73365    72640     -725     
- Partials      364      369       +5     

@bruno-garcia
Copy link
Member Author

Test failures seem like flakes:

provisionSubscriptionAction calls api with correct mm2 args
provisionSubscriptionAction calls api with correct manually invoiced on-demand args

@ryan953
Copy link
Member

ryan953 commented Jul 10, 2025

Test failures seem like flakes:

re-ran them, look passing now

@scttcper
Copy link
Member

scttcper commented Jul 10, 2025

the scroll bar being visible is a user setting. This is what it looks like for me on prod
image

i think there's some widths here where its overflowing from the current changes
image

you could also try setting the modal width to 100vw or something https://github.com/getsentry/sentry/blob/master/static/app/components/events/interfaces/debugMeta/debugImageDetails/index.tsx#L371-L381

@bruno-garcia
Copy link
Member Author

beyond my or cursors skill at this problem so I'll give up

@bruno-garcia bruno-garcia deleted the cursor/adjust-layout-for-button-visibility-e987 branch July 10, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants