-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(user feedback): update default title for tickets created from user feedback #94889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user feedback): update default title for tickets created from user feedback #94889
Conversation
- Replace hardcoded 'User Feedback' title with dynamic generation - Add generate_feedback_title() function that creates titles like 'User Feedback: [first few words]...' - Handle edge cases: empty messages, long messages, special characters - Add comprehensive tests for title generation functionality - Maintain backwards compatibility - only affects new feedback issues - Supports external integrations (JIRA, GitHub, Linear) with better context
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Michelle Zhang <[email protected]>
one thing to note is rely on the "user feedback" title string on the frontend in our breadcrumbs to identify feedback issue breadcrumbs, so if this gets merged we need to update this: sentry/static/app/utils/replays/hydrateErrors.tsx Lines 25 to 73 in 99b5fa0
|
@django_db_all | ||
def test_create_feedback_issue_uses_generated_title( | ||
default_project, mock_produce_occurrence_to_kafka | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete this test because other tests should pickup the title change and need to be fixed up
it's suspicious that they're not failing though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's valuable to test the method still to verify its behavior is as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would have to add tests further down the issue creation pipeline, but i doubt any tests exist right now to check specifically for the title of feedback issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other tests don't check the issue_title field, i think including this one makes sense
d1d6970
to
5590ebc
Compare
…er feedback (#94889) For external issues, the current default title "User Feedback" is generic and lacks context when integrated with external systems like JIRA, GitHub, or Linear. This PR updates the issue title to contain the first few words of the feedback message (by default, first 10 words). Fixes #76156 --------- Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Michelle Zhang <[email protected]>
For external issues, the current default title "User Feedback" is generic and lacks context when integrated with external systems like JIRA, GitHub, or Linear.
This PR updates the issue title to contain the first few words of the feedback message (by default, first 10 words).
Fixes #76156