ref: Introduce a few style improvements #94904
Open
+32
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
Jul 4, 2025
| return ( | ||
| <Container className={className}> |
There was a problem hiding this comment.
Because we use PanelItem here, in the modal, the image contains padding and it shouldn't. This component should contain img only element and no wrappers
| {t('Your browser does not support the video tag.')} | ||
| </video> | ||
| </PanelItem> | ||
| <video |
| @@ -35,8 +36,7 @@ export function InlineEventAttachment({ | |||
| ); | |||
| } | |||
|
|
|||
| const AttachmentPreviewWrapper = styled('div')` | |||
| const AttachmentPreviewWrapper = styled(PanelItem)` | |||
There was a problem hiding this comment.
The PanelItem should instead be used here where we are using a Panel
| @@ -187,9 +187,10 @@ const AttachmentComponentWrapper = styled('div')` | |||
| & > video { | |||
| max-width: 100%; | |||
| max-height: calc(100vh - 300px); | |||
| width: auto; | |||
| width: 100%; | |||
There was a problem hiding this comment.
fixing this for videos
| height: auto; | ||
| object-fit: contain; | ||
| border-radius: ${p => p.theme.borderRadius}; |
There was a problem hiding this comment.
it looks better with border-radius, aligning with the panel with data below it
Base automatically changed from
priscila/feat/attachments/add-more-video-types
to
master
July 4, 2025 10:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Tested everything and believe me - it looks great! Unfortunately, due to issues with
dev-uiI can't provide before and after screenshots.Contributes to https://linear.app/getsentry/issue/TET-614/attachments-add-support-for-newer-file-formats-such-as-heic