fix(dashboards): Invalidate starred query data using correct queryKey #94925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper does a feature flag check to invalidate the correct key since the URLs are different.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
changed the title
edwardgou-sentry
approved these changes
Jul 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
…#94925) The helper does a feature flag check to invalidate the correct key since the URLs are different. Fixes the scenario where the sidebar is in its dynamic state, you rearrange, and when you hover out and back onto the dashboards list, the dashboards should be in the new order. They were in the old order because we didn't invalidate the cache with the new query key. After the feature flag gets removed I'll just hardcode the query key instead of exporting it/getting it through the helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper does a feature flag check to invalidate the correct key since the URLs are different. Fixes the scenario where the sidebar is in its dynamic state, you rearrange, and when you hover out and back onto the dashboards list, the dashboards should be in the new order.
They were in the old order because we didn't invalidate the cache with the new query key. After the feature flag gets removed I'll just hardcode the query key instead of exporting it/getting it through the helper